You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, mouse velocity is updated when set_mouse_position() is called. This has two side effects:
Mouse velocity is updated every time set_mouse_position() is called even when the mouse hasn't moved. This results in large mouse velocities when, for example, the mouse is warped.
Mouse velocity is not updated when the mouse moves, but the mouse position doesn't change. This results in mouse velocities being zero when using MOUSE_MODE_CAPTURED.
This PR uses InputEventMouseMotion's relative motion to update the mouse's velocity instead of calls to set_mouse_position(). This ensures that mouse velocities are updated when the mouse is captured.
Note: set_mouse_position() tends to be called to update the velocity before setting a InputEventMouseMotion's velocity property using get_last_mouse_velocity(). With this change the velocity (and position) aren't updated until the event is parsed. So calling set_mouse_position() to update the velocity is no longer meaningful. Therefore, these lines have been removed. Although it would appear that this would make the velocity value used in InputEventMouseMotion out of date, the reality is that, to ensure the velocity is precise and not jittery, the velocity is only updated every 0.1 seconds. This is far less frequent than InputEventMouseMotion events are generated (around every 0.008 seconds). Therefore, calling set_mouse_position() to update the velocity before setting a InputEventMouseMotion's velocity property, was ineffective anyway.
Note2: This change doesn't fix mouse warping from setting the mouse velocity. Mouse warping events should be filtered. However, at least on Linux, this is not happening. See #8414, which is still happening even though the issue has been closed.
Note3: #45592, reports a different issue, which highlighted a different problem: mouse velocities are not properly clearing old residual movements. However, #45592 arose, because of trying to find a workaround to mouse speeds being zero, when using MOUSE_MODE_CAPTURED.
Note2: This change doesn't fix mouse warping from setting the mouse velocity. Mouse warping events should be filtered. However, at least on Linux, this is not happening. See #8414, which is still happening even though the issue has been closed.
Not a Linux specific issue, it's the same on macOS.
Note2: This change doesn't fix mouse warping from setting the mouse velocity. Mouse warping events should be filtered. However, at least on Linux, this is not happening. See #8414, which is still happening even though the issue has been closed.
Not a Linux specific issue, it's the same on macOS.
I would suggest opening a new issue. Reopening a 2017 issue won't give it much visibility and it lacks a reproduction project.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, mouse velocity is updated when
set_mouse_position()is called. This has two side effects:set_mouse_position()is called even when the mouse hasn't moved. This results in large mouse velocities when, for example, the mouse is warped.MOUSE_MODE_CAPTURED.This PR uses
InputEventMouseMotion's relative motion to update the mouse's velocity instead of calls toset_mouse_position(). This ensures that mouse velocities are updated when the mouse is captured.Note:
set_mouse_position()tends to be called to update the velocity before setting aInputEventMouseMotion'svelocityproperty usingget_last_mouse_velocity(). With this change the velocity (and position) aren't updated until the event is parsed. So callingset_mouse_position()to update the velocity is no longer meaningful. Therefore, these lines have been removed. Although it would appear that this would make the velocity value used inInputEventMouseMotionout of date, the reality is that, to ensure the velocity is precise and not jittery, the velocity is only updated every 0.1 seconds. This is far less frequent thanInputEventMouseMotionevents are generated (around every 0.008 seconds). Therefore, callingset_mouse_position()to update the velocity before setting aInputEventMouseMotion'svelocityproperty, was ineffective anyway.Note2: This change doesn't fix mouse warping from setting the mouse velocity. Mouse warping events should be filtered. However, at least on Linux, this is not happening. See #8414, which is still happening even though the issue has been closed.
Note3: #45592, reports a different issue, which highlighted a different problem: mouse velocities are not properly clearing old residual movements. However, #45592 arose, because of trying to find a workaround to mouse speeds being zero, when using
MOUSE_MODE_CAPTURED.