Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport some changes to 3.x shaders #56794

Merged
merged 1 commit into from
Jan 25, 2022
Merged

Backport some changes to 3.x shaders #56794

merged 1 commit into from
Jan 25, 2022

Conversation

Chaosus
Copy link
Member

@Chaosus Chaosus commented Jan 14, 2022 •
edited
Loading

@Chaosus Chaosus requested a review from a team as a code owner January 14, 2022 19:22
@Chaosus Chaosus added this to the 3.5 milestone Jan 14, 2022
akien-mga
akien-mga approved these changes Jan 14, 2022
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved on the principle, I'll let you make sure that it's well tested and working before merging :)

@Chaosus Chaosus marked this pull request as draft January 14, 2022 19:46
@Chaosus Chaosus force-pushed the shader_fixes_3.x branch 3 times, most recently from e6eeb94 to 3fd8b01 Compare January 15, 2022 14:28
@Chaosus Chaosus marked this pull request as ready for review January 25, 2022 07:42
@Chaosus Chaosus merged commit cb9854d into godotengine:3.x Jan 25, 2022
@Chaosus Chaosus deleted the shader_fixes_3.x branch January 25, 2022 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
enhancement topic:shaders
Projects
None yet
Milestone
3.5
Development

Successfully merging this pull request may close these issues.
2 participants
@Chaosus @akien-mga