Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider gridmap collisions in navigation bake #56855

Merged
merged 1 commit into from
Jan 20, 2022
Merged

Consider gridmap collisions in navigation bake #56855

merged 1 commit into from
Jan 20, 2022

Conversation

rafallus
Copy link
Contributor

NavigationRegion3D now takes into account collision shapes from GridMap when baking navigation meshes (it was taking into account only meshes).
Solves: godotengine/godot-proposals#1948

I used this project to test
GridMapNavigationBake.zip

@rafallus rafallus requested a review from a team as a code owner January 17, 2022 01:07
@Calinou Calinou added this to the 4.0 milestone Jan 17, 2022
@akien-mga akien-mga requested a review from a team January 17, 2022 06:48
akien-mga
akien-mga approved these changes Jan 17, 2022
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't do a qualified review on the actual implementation details for navigation and physics (that will be for @godotengine/navigation), but in terms of code quality and scope this looks pretty good to me.

@akien-mga akien-mga merged commit 65c3f2c into godotengine:master Jan 20, 2022
@akien-mga
Copy link
Member

Thanks!

@akien-mga
Copy link
Member

Sounds like a feature worth backporting to 3.x, feel free to make a dedicated PR for it.

@akien-mga akien-mga mentioned this pull request Jan 20, 2022
Closed
@rafallus rafallus deleted the gridmap_bake_staticbody branch January 24, 2022 22:39
@rafallus rafallus mentioned this pull request Jan 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
enhancement topic:navigation topic:3d
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@rafallus @akien-mga @Calinou