Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DUPLICATE_INTERNAL_STATE flag #57121

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Jan 24, 2022

Resolves #3393

@KoBeWi KoBeWi added this to the 4.0 milestone Jan 24, 2022
@KoBeWi KoBeWi requested review from a team as code owners January 24, 2022 13:54
@KoBeWi KoBeWi force-pushed the noddeganger branch 2 times, most recently from 5677b59 to 13f8e72 Compare January 24, 2022 16:30
@YuriSizov YuriSizov modified the milestones: 4.0, 4.x Aug 16, 2022
@YuriSizov
Copy link
Contributor

Is this still needed? @kubecz3k doesn't seem to recall if it is 🙃

@KoBeWi
Copy link
Member Author

KoBeWi commented Aug 16, 2022

Well, internal (non-exported) properties are still not duplicated, soo...

@kubecz3k
Copy link
Contributor

kubecz3k commented Aug 17, 2022

So I updated the original issue by converting reproduction project from Godot (1.x?) to Godot 4. I can confirm the issue is still the same.

Also to clarify: the issue is about usage of Object.duplicate() method and the fact that variables of returned object (even simple types) are different from the object from which it has been duplicated

Leaved some additional comment in the issue #3393 (comment)

@KoBeWi KoBeWi force-pushed the noddeganger branch 2 times, most recently from 53d397e to d040f0d Compare March 12, 2024 19:22
@KoBeWi KoBeWi requested review from a team as code owners March 12, 2024 19:22
@KoBeWi KoBeWi force-pushed the noddeganger branch 5 times, most recently from 2784e61 to 406e926 Compare March 12, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node duplicate() doesn't copy internal variables values
3 participants