Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support WebM seeking operation #57690

Closed
wants to merge 3 commits into from
Closed

Support WebM seeking operation #57690

wants to merge 3 commits into from

Conversation

John-Gdi
Copy link
Contributor

@John-Gdi John-Gdi commented Feb 6, 2022

Support webm video seeking operation with minimal modification. Currently, it only support 3.x version since master 4.0 version has abandoned webm format support.

Modified files:
1.modules/webm/video_stream_webm.cpp
2.thirdparty/libsimplewebm/WebMDemuxer.cpp
3.thirdparty/libsimplewebm/WebMDemuxer.hpp
Kapture.2022-02-06.at.11.49.43.mp4

@fire
Copy link
Member

fire commented Feb 6, 2022

There's a whitespace formatting change that needs to be applied.

@John-Gdi
Copy link
Contributor Author

John-Gdi commented Feb 6, 2022

There's a whitespace formatting change that needs to be applied.

Thanks, and i have modified the formatting change

@akien-mga
Copy link
Member

There will be more style issues to fix, see https://docs.godotengine.org/en/stable/community/contributing/code_style_guidelines.html

But this PR should be reopened against the 3.x branch, that's where feature development for 3.5 is done.

@John-Gdi
Copy link
Contributor Author

John-Gdi commented Feb 6, 2022

There will be more style issues to fix, see https://docs.godotengine.org/en/stable/community/contributing/code_style_guidelines.html

But this PR should be reopened against the 3.x branch, that's where feature development for 3.5 is done.

Thanks for your guidance, and i correct the issue according to the guidelines, as well as the suggestion from @Calinou , before the third commit, i have use pre-commit to ensure that "Files in this commit comply with the clang-format rules."

When this PR is Ready, i will reopen it on 3.x branch, and open PR on 3.x first next time, Thanks.

@fire
Copy link
Member

fire commented Mar 2, 2022

I have asked @kidrigger to review and am testing too.

@akien-mga
Copy link
Member

Superseded by #57744.

@akien-mga akien-mga closed this Jul 2, 2022
@akien-mga akien-mga modified the milestones: 3.5, 3.4 Jul 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants