Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix get_base_dir returning same path, if slash is in the end #58508

Closed
wants to merge 1 commit into from
Closed

Fix get_base_dir returning same path, if slash is in the end #58508

wants to merge 1 commit into from

Conversation

Akylzhan
Copy link

Fixes #58504

@Akylzhan Akylzhan requested a review from a team as a code owner February 24, 2022 19:36
@Chaosus Chaosus added this to the 4.0 milestone Feb 25, 2022
@clayjohn clayjohn requested a review from mhilbrunner August 18, 2022 15:45
@akien-mga akien-mga requested a review from bruvzg February 13, 2023 12:02
@akien-mga akien-mga modified the milestones: 4.0, 4.1 Feb 13, 2023
@akien-mga
Copy link
Member

Would be good to rebase to make sure it still builds and works fine, and to add some test cases to tests/core/string/test_string.h.

Notably it should test a few combinations of paths with a trailing slash, like:

some/nested/path/
some/
/absolute/nested/path/
/absolute/
/
../

@akien-mga akien-mga modified the milestones: 4.1, 4.2 Jun 15, 2023
@Alex2782 Alex2782 mentioned this pull request Sep 29, 2023
Closed
@AThousandShips AThousandShips modified the milestones: 4.2, 4.3 Oct 27, 2023
@AThousandShips
Copy link
Member

The issue has been closed and was closed by:

This might be unnecessary now

@akien-mga akien-mga closed this Oct 30, 2023
@akien-mga akien-mga removed this from the 4.3 milestone Oct 30, 2023
@Akylzhan Akylzhan deleted the path-fix branch November 13, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhilbrunner mhilbrunner Awaiting requested review from mhilbrunner

@bruvzg bruvzg Awaiting requested review from bruvzg

Assignees
No one assigned
Labels
archived bug topic:core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Godot 4: Need to press "Directory Up" button twice in path with slash at the end
6 participants
@Akylzhan @akien-mga @AThousandShips @KoBeWi @Chaosus @clayjohn