Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.x] Make string inside TTR() single-line #58627

Merged
merged 1 commit into from
Mar 1, 2022
Merged

[3.x] Make string inside TTR() single-line #58627

merged 1 commit into from
Mar 1, 2022

Conversation

timothyqiu
Copy link
Member

Currently TTR() extraction only works line by line, so only the first line is extracted:

godot/editor/translations/editor.pot

Lines 13308 to 13312 in a76316c

#: platform/android/export/export_plugin.cpp
msgid ""
"Invalid \"GodotPaymentV3\" module included in the \"android/modules\" "
"project setting (changed in Godot 3.2.2).\n"
msgstr ""

@timothyqiu timothyqiu added this to the 3.5 milestone Feb 28, 2022
@timothyqiu timothyqiu requested a review from a team as a code owner February 28, 2022 12:23
@timothyqiu timothyqiu mentioned this pull request Feb 28, 2022
Merged
m4gr3d
m4gr3d approved these changes Mar 1, 2022
View reviewed changes
Copy link
Contributor

@m4gr3d m4gr3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@m4gr3d m4gr3d merged commit 19ec1c2 into godotengine:3.x Mar 1, 2022
@timothyqiu timothyqiu deleted the i18n-multiline branch March 1, 2022 09:50
@akien-mga
Copy link
Member

Cherry-picked for 3.4.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m4gr3d m4gr3d m4gr3d approved these changes

Assignees
No one assigned
Labels
bug platform:android topic:editor
Projects
None yet
Milestone
3.5
Development

Successfully merging this pull request may close these issues.
3 participants
@timothyqiu @akien-mga @m4gr3d