Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UndoRedo method call argument count after #58929 #58950

Merged
merged 1 commit into from
Mar 9, 2022

Conversation

akien-mga
Copy link
Member

After #58929 the editor would throw errors like this:

ERROR: Error calling method from signal 'set_current_version': 'EditorNode::set_current_version': Method expected 1 arguments, but called with 0.
   at: _process_operation_list (core/object/undo_redo.cpp:326)
ERROR: Error calling method from signal 'set_current_scene': 'EditorNode::set_current_scene': Method expected 1 arguments, but called with 0.
   at: _process_operation_list (core/object/undo_redo.cpp:326)
ERROR: Error calling method from signal 'set_current_version': 'EditorNode::set_current_version': Method expected 1 arguments, but called with 0.
   at: _process_operation_list (core/object/undo_redo.cpp:326)

And most functionality relying on UndoRedo is broken (e.g. adding a Node to the scene tree dock).

@akien-mga akien-mga added this to the 4.0 milestone Mar 9, 2022
@akien-mga akien-mga requested a review from a team as a code owner March 9, 2022 21:22
@Sauermann
Copy link
Contributor

This patch fixes the problem for me.

@akien-mga akien-mga merged commit 450ebaa into godotengine:master Mar 9, 2022
@akien-mga akien-mga deleted the fix-undoredo-argcount branch March 9, 2022 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants