[4.0] Fix alpha scissor support #58954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry about the repush, just realized that I forgot to remove an unnecessary pair of brackets. |
clayjohn
reviewed
Mar 11, 2022
|
Right, there are two vulkan renderers in master... I keep forgetting the mobile one every single time. |
clayjohn
reviewed
Mar 11, 2022
servers/rendering/renderer_rd/forward_mobile/scene_shader_forward_mobile.cpp
Outdated
Show resolved
Hide resolved
clayjohn
approved these changes
Mar 17, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #58924 in master.
Apparently, the alpha scissor check was lost in the transition from gles3 to vulkan. In addition materials with alpha scissors were still using the default shadow material, which obviously resulted in wrong shadows.