[3.x] instance audio streams before AudioServer::lock call #59413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closed by accident. |
ellenhp
force-pushed
the
preinstance-audio-streams
branch
from
e351a0f
to
027546e
Compare
|
Thanks! |
|
Cherry-picked for 3.4.5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22016 in 3.x
This was fixed in
masterby #51296The bug seems to be caused by an underrun due to the
set_streamcalls holding the global audio server lock during instancing of an ogg stream. It does seem like several different bugs may have been tracked by that issue at some point or another, but the only repro I have is caused by an underrun and this seems to fix it.