Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep editor at normal priority on windows. #59665

Merged
merged 1 commit into from
Mar 29, 2022
Merged

Keep editor at normal priority on windows. #59665

merged 1 commit into from
Mar 29, 2022

Conversation

lyuma
Copy link
Contributor

@lyuma lyuma commented Mar 29, 2022

The multithreaded importer often causes system-wide hangs when importing more than 20 files at a time.
Running the editor at normal priority allows other applications on the system to be responsive during long imports.

This is a forward port of the change here by @Calinou :
3.x...Calinou:windows-editor-use-normal-priority-3.x

I could find the existing PR for this, but this change is working well for me on master.

@lyuma
Keep editor at normal priority on windows.
ee02a7f 
The multithreaded importer often causes system-wide hangs when importing more than 20 files at a time.
Running the editor at normal priority allows other applications on the system to be responsive during long imports.
@lyuma lyuma requested a review from a team as a code owner March 29, 2022 09:42
@akien-mga akien-mga added this to the 4.0 milestone Mar 29, 2022
@akien-mga akien-mga added the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Mar 29, 2022
@fire fire requested a review from a team March 29, 2022 10:49
akien-mga
akien-mga approved these changes Mar 29, 2022
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me and the implementation is correct. I'll let @bruvzg confirm for Windows-specific knowledge.

bruvzg
bruvzg approved these changes Mar 29, 2022
View reviewed changes
Copy link
Member

@bruvzg bruvzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it makes sense. Above-normal usually should not cause system to hand, but non-time-critical apps, like editor, should not run with elevated priority either.

@akien-mga akien-mga merged commit ab24fb2 into godotengine:master Mar 29, 2022
@akien-mga
Copy link
Member

Thanks!

@akien-mga
Copy link
Member

Cherry-picked for 3.5.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Apr 13, 2022
@lyuma lyuma deleted the editor_normal_priority branch May 19, 2023 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

@bruvzg bruvzg bruvzg approved these changes

Assignees
No one assigned
Labels
enhancement platform:windows topic:porting
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@lyuma @akien-mga @bruvzg