Fixed rotated RootMotionView grid glitch #60349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh something is still wrong, maybe something needs to be fixed comprehensively for RootMotion. |
|
Bugs about drawing can be fixed in this PR, but additional fixes may be needed later in AnimationTree for rotation. Edited: So this PR is now fine. |
TokageItLab
force-pushed
the
fix-rotated-root-motion-view
branch
from
cc8c952 to
df89969
Compare
TokageItLab
added
the
cherrypick:3.x
reduz
reviewed
Apr 27, 2022
| from = accumulated.xform(from); | ||
| from_i = accumulated.xform(from_i); | ||
| from_j = accumulated.xform(from_j); | ||
| from = accumulated.xform_inv(from); |
There was a problem hiding this comment.
Is this ok? remember that if scale is present, xform_inv will not work.
There was a problem hiding this comment.
@reduz transform's scale has been orthonormalized in line 116, so always accumulated's scale is should be 1.
reduz
approved these changes
Apr 27, 2022
|
Thanks! |
|
Cherry-picked for 3.5. |
akien-mga
removed
the
cherrypick:3.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #60342. It should be
fposmod()in normal space, not in inverted space.Before:
2022-04-25.20.32.34-1.mov
After:
2022-04-25.20.30.52-1.mov
turn_rotation_root.zip