Use S, V in hue bar of ColorPicker

[KoBeWi]

[groud]

Hmm, are other software doing it like this ? I suppose it's a more adequate way to visualize what will happen when you change the slider, but on the other hand it kind of make it impossible to set the hue first when the color defaults to white.

[KoBeWi]

Hmm, are other software doing it like this ?

I've seen this in GIMP

it kind of make it impossible to set the hue first when the color defaults to white.

Yeah, that could be an issue. On the other hand, setting hue first has no effect, so displaying it as white is more accurate.

[groud]

On the other hand, setting hue first has no effect

Yeah, of course, but with the colorful slider, you can still set an approximate hue first, which is very difficult without it.

I think the issue is quite important for the hue slider, as, unlike the other ones, it's a little bit harder a to "map" a given value to what it corresponds to. I mean that it is easy to understand what a value of 200 means for saturation (it's an "high but not to the max" saturation), but I have no clue what a 200 in hue means.

I am not sure how we can solve that though. I think that, ideally, we would have a way to display both at the same time? But I guess the two bars would need to be separated one way or another, as, otherwise, it might get hard to read.

[KoBeWi]

btw OKHSL color mode has similar behavior (and issues...):

[fire]

Does #67534 resolve any of these issues?

[KoBeWi]

Not really. Not sure if it's even fixable, because technically the colors are displayed correctly. So it's just sliders are not very useful for OKHSL.

[KoBeWi]

Rebased. I also added the same for OKHSL. This mode is weird, because changing hue seems to affect brightness, but well 🤔

GnsH8MXB8M.mp4

tbh I'm not 100% sure about this change either. It makes the displayed color more accurate at a cost of some usability. I opened the PR because it bothered me that hue bar doesn't change.

[Calinou]

On principle, I like the idea of this 🙂

I've tested a version locally rebased against master, it looks like this:

HSV

OKHSL

The hue slider is rotated. I just accepted the incoming changes as-is when rebasing, which I guess is incorrect due to 84d6549.

[Calinou]

For reference, GIMP's color picker behaves this way too – it displays previews on all sliders when in HSV mode:

[KoBeWi]

Rebased. I also fixed OKHSL mode (it was using HSV functions).

EDIT:
GitHub did not pickup my push for whatever reason 🤔

[Calinou]

GitHub did not pickup my push for whatever reason 🤔

That's strange, I see your latest commit on your fork: https://github.com/KoBeWi/Godot/tree/%F0%9F%8D%9D

That said, static checks are failing.

[KoBeWi]

Static checks are outdated.

[KoBeWi]

I am still unable to revive this. I'll reopen a new PR with a new branch.

EDIT:
Seems like I can't delete branch nor reopen the PR now 🤔