Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rotation unit tests for Transform3D #61013

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented May 13, 2022

Follow-up to #61008. This salvages #43694.

Thanks @AlexanderPruss for the original PR 🙂

tests/core/math/test_transform_3d.h Outdated Show resolved Hide resolved
@Geometror
Copy link
Member

There were some rudimentary test cases added for Transform3D with #55923. There might be some overlap, but I think this can be salvaged.

@YuriSizov YuriSizov modified the milestones: 4.0, 4.1 Feb 10, 2023
@YuriSizov YuriSizov modified the milestones: 4.1, 4.x Jun 14, 2023
Co-authored-by: Alexander Pruss <alex.pruss@gmail.com>
@Calinou Calinou changed the title Add a partial test suite for Transform3D Add rotation unit tests for Transform3D Apr 10, 2024
@akien-mga akien-mga modified the milestones: 4.x, 4.3 Apr 18, 2024
@akien-mga akien-mga merged commit 0f7452f into godotengine:master Apr 19, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@Calinou Calinou deleted the test-add-transform3d branch April 22, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants