Clamp NavigationMesh sample_distance above zero #61061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
added
bug
topic:editor
crash
cherrypick:3.x
akien-mga
reviewed
May 16, 2022
akien-mga
approved these changes
May 16, 2022
While default ReCast library has support for 0.0 'sample_distance' the Godot implementation does not an crashes. Previously Godot would set all sample_distance values below 0.9 to 0 which causes the crashes. This limits the sample_distance range selection to 0.1 - 16.0 and also clamps sample_distance that are below 0.1 before ReCast receives them.
smix8
force-pushed
the
navigation_mesh_sample_distance_range_4.x
branch
from
abe236e
to
e33fa9d
Compare
akien-mga
approved these changes
May 16, 2022
|
Thanks! |
|
Cherry-picked for 3.5. |
akien-mga
removed
the
cherrypick:3.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously Godot would set all
sample_distancevalues < 0.9 to 0 which causes the crashes. This pr limits the sample_distance range selection to 0.1 - 16.0 and also clamps sample_distance that are below 0.1 before ReCast receives them.While default ReCast library has support for 0.0 and >= 0.9 'sample_distance' the Godot implementation does not for a zero value. In fact against the ReCast doc numbers below 0.9 also work in Godot. Godot was already using values as low as 0.01 on small grids cause the Godot implementation is multiplying the
sample_distancewithcell_sizebehind the scene and cell_size can get as low as 0.1 in value.Fixes #38173