Implement read-only dictionaries. #61087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
BTW, the only thing I miss for adding this to GDScript is some better error reporting. Function calls (like |
|
@vnen I am not sure, I added the code so it reports an error when you set to variant_setget.cpp, so I am not sure why it is not working for you. |
|
Nevermind, I had to use something else for this. |
* Add ability to set them read only. * If read-only, it can't be modified. This is added in order to optionally make const dictionaries (and eventually arrays) properly read-only in GDScript.
reduz
force-pushed
the
readonly-dictionary
branch
from
d759ecd to
e6c443a
Compare
|
Alright, should now work as intended. |
|
@vnen It will throw a generic invalid set index error, but you can check in the VM whether an error happened and check if the base is a dictionary and is readonly and show the relevant thing. |
|
@reduz now it does throw an error when trying to set, so it's good to go. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is added in order to optionally make const dictionaries (and eventually arrays) properly read-only in GDScript.
Implementation notes: This is implemented in a way that should have little to no cost if read-only is disabled. The main problem is that C++ does not necessarily prefer const overloads, so it may be possible that a non-const one is used to read data (and not modify it). For this a copy needs to be made to ensure no contents are overwritten.
In practice though, this should never happen because in no place Godot APIs take pointers or references to dictionaries for just reading, and the binder API also does not support this.