Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Make various improvements to OptionButton #61102

Merged
merged 1 commit into from
May 16, 2022
Merged

[3.x] Make various improvements to OptionButton #61102

merged 1 commit into from
May 16, 2022

Conversation

okla
Copy link

@okla okla commented May 16, 2022

3.x version of #57330

- Allow OptionButton selection to be set to -1 to signify no selection, both via API and in the editor.
- Reset OptionButton selection to -1 when the selected item has been removed.
- Fully convert PopupMenu to a zero-based ID system, which improves an inconsistency in generated IDs when making new items in the editor.

(cherry picked from commit 3b146c5)
@okla okla marked this pull request as ready for review May 16, 2022 21:16
@okla okla requested review from a team as code owners May 16, 2022 21:16
@Calinou Calinou added this to the 3.5 milestone May 16, 2022
@akien-mga akien-mga merged commit 281c5c9 into godotengine:3.x May 16, 2022
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants