Use % when dropping unique scene nodes into script #61148
Merged
+12
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timothyqiu
reviewed
May 18, 2022
There was a problem hiding this comment.
I think you just have to replace path here with "%" + node->get_name() when it's a unique name.
godot/editor/plugins/script_text_editor.cpp
Line 1571 in 26393cc
Done. |
KoBeWi
reviewed
May 18, 2022
This expands uppon godotengine#60708, using `get_node("%NodeName")` for nodes that have a unique scene name to avoid having to change the onready statements when the paths of the nodes change.
KoBeWi
approved these changes
May 18, 2022
|
Thanks! |
timothyqiu
added
the
cherrypick:3.x
|
Tested locally. I think this PR is also good to cherrypick to |
|
Cherry-picked for 3.5. |
akien-mga
removed
the
cherrypick:3.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This expands upon #60708, using
get_node("%NodeName")for nodes that have a unique scene name to avoid having to change the onready statements when the paths of the nodes change.Preview: