Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dedicated macros for property name extraction #61180

Merged
merged 1 commit into from
May 19, 2022

Conversation

timothyqiu
Copy link
Member

master version of #61141

Additional changes:

  • Extract ADD_ARRAY*, ADD_SUBGROUP* standard macros
  • GNAME is not used anywhere here, but defined to be consistent.

* Replace case-by-case extraction with PNAME & GNAME
* Fix group handling when group hint begins with property name
* Exclude properties that are PROPERTY_USAGE_NO_EDITOR
* Extract missing ADD_ARRAY*, ADD_SUBGROUP* macros
@timothyqiu timothyqiu added this to the 4.0 milestone May 19, 2022
@timothyqiu timothyqiu requested review from a team as code owners May 19, 2022 07:15
@akien-mga akien-mga merged commit 71c40ff into godotengine:master May 19, 2022
@akien-mga
Copy link
Member

Thanks!

@timothyqiu timothyqiu deleted the property-extract branch May 19, 2022 10:03
akien-mga added a commit to akien-mga/godot that referenced this pull request Jun 10, 2022
akien-mga added a commit that referenced this pull request Jun 10, 2022
…erty-name

SoftBody: Fix attachments property names after #61180
akien-mga added a commit that referenced this pull request Jun 10, 2022
Riordan-DC pushed a commit to Riordan-DC/godot that referenced this pull request Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants