gltf: Allow more than 4 joints but warn and ignore them. #61912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lyuma
force-pushed
the
allow_more_than_four_weights
branch
from
33c60d2
to
7d970b9
Compare
akien-mga
reviewed
Jun 11, 2022
| if (a.has("WEIGHTS_0") && !a.has("WEIGHTS_1")) { | ||
| if (a.has("WEIGHTS_1") && a.has("JOINTS_1")) { | ||
| if (!has_warned) { | ||
| WARN_PRINT("glTF: Meshes use more than 4 bone joints"); |
There was a problem hiding this comment.
Need testing, but WARN_PRINT_ONCE should do what you're reimplementing with the bool.
There was a problem hiding this comment.
It might not work as "once per file" though, so this approach might be best.
akien-mga
approved these changes
Jun 11, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #56705
Removes check for WEIGHTS_1 and JOINTS_1 and allows the normalization code to execute on the first 4 joints - this likely brings back the old Godot 3.2 behavior, and this is legal glTF 2.0 behavior
Prints a warning once per file if any meshes had extra joints:
I'm assuming that the 4 most important influences will be saved into JOINTS_0 but I do not know if this is guaranteed.
