Mark some common project settings as basic #61974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronRecord
approved these changes
Jun 12, 2022
akien-mga
reviewed
Jun 12, 2022
| @@ -4929,7 +4929,7 @@ bool EditorNode::is_run_playing() const { | |||
| String EditorNode::get_run_playing_scene() const { | |||
| String run_filename = editor_run.get_running_scene(); | |||
| if (run_filename.is_empty() && is_run_playing()) { | |||
| run_filename = GLOBAL_DEF("application/run/main_scene", ""); // Must be the main scene then. | |||
| run_filename = GLOBAL_DEF_BASIC("application/run/main_scene", ""); // Must be the main scene then. | |||
There was a problem hiding this comment.
Settings shouldn't be defined twice. And I feel EditorNode is not the right place to define this, it's used and should be defined in Main IMO.
fire
approved these changes
Jun 13, 2022
Fair enough, there's quite a few in that situation. |
|
Thanks! |
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This marks advanced settings that were agreed upon in #50620 as basic.