Add an option to drag'n'drop selected text in TextEdit
#62221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YuriSizov
changed the title
TextEdit
|
Please amend your commit message to follow the preferred format, "Verb + more descriptive statement about what changed". See the updated PR title for example. 🙃 |
ConteZero
force-pushed
the
drag_and_drop_option
branch
from
007682d
to
b50d21b
Compare
Paulb23
requested changes
Jun 25, 2022
scene/gui/text_edit.cpp
Outdated
Comment on lines
+4461
to
+4468
| void TextEdit::set_drag_and_drop_selection_enabled(const bool p_enabled) { | ||
| drag_and_drop_selection_enabled = p_enabled; | ||
| } | ||
|
|
||
| bool TextEdit::is_drag_and_drop_selection_enabled() const { | ||
| return drag_and_drop_selection_enabled; | ||
| } | ||
|
|
There was a problem hiding this comment.
.h and .c content should follow the same order, so this should be under delete_selection below, same with the other changes. Including moving drag_and_drop_selection_enabled under selection.
Nitpick: Would move it under is_deselect_on_focus_loss_enabled
ConteZero
force-pushed
the
drag_and_drop_option
branch
from
b50d21b
to
3a9d4a9
Compare
Paulb23
approved these changes
Jun 26, 2022
akien-mga
reviewed
Jun 26, 2022
doc/classes/TextEdit.xml
Outdated
| @@ -956,6 +956,9 @@ | |||
| <member name="deselect_on_focus_loss_enabled" type="bool" setter="set_deselect_on_focus_loss_enabled" getter="is_deselect_on_focus_loss_enabled" default="true"> | |||
| If [code]true[/code], the selected text will be deselected when focus is lost. | |||
| </member> | |||
| <member name="drag_and_drop_selection" type="bool" setter="set_drag_and_drop_selection_enabled" getter="is_drag_and_drop_selection_enabled" default="true"> | |||
| If [code]true[/code] allow drag and drop of selected text. | |||
There was a problem hiding this comment.
Suggested change
| If [code]true[/code] allow drag and drop of selected text. | |
| If [code]true[/code], allow drag and drop of selected text. |
akien-mga
reviewed
Jun 26, 2022
scene/gui/text_edit.cpp
Outdated
| @@ -5405,6 +5416,7 @@ void TextEdit::_bind_methods() { | |||
| ADD_PROPERTY(PropertyInfo(Variant::BOOL, "shortcut_keys_enabled"), "set_shortcut_keys_enabled", "is_shortcut_keys_enabled"); | |||
| ADD_PROPERTY(PropertyInfo(Variant::BOOL, "selecting_enabled"), "set_selecting_enabled", "is_selecting_enabled"); | |||
| ADD_PROPERTY(PropertyInfo(Variant::BOOL, "deselect_on_focus_loss_enabled"), "set_deselect_on_focus_loss_enabled", "is_deselect_on_focus_loss_enabled"); | |||
| ADD_PROPERTY(PropertyInfo(Variant::BOOL, "drag_and_drop_selection"), "set_drag_and_drop_selection_enabled", "is_drag_and_drop_selection_enabled"); | |||
There was a problem hiding this comment.
Suggested change
| ADD_PROPERTY(PropertyInfo(Variant::BOOL, "drag_and_drop_selection"), "set_drag_and_drop_selection_enabled", "is_drag_and_drop_selection_enabled"); | |
| ADD_PROPERTY(PropertyInfo(Variant::BOOL, "drag_and_drop_selection_enabled"), "set_drag_and_drop_selection_enabled", "is_drag_and_drop_selection_enabled"); |
To be consistent with other bool properties in the same class.
ConteZero
force-pushed
the
drag_and_drop_option
branch
from
3a9d4a9
to
5d56efc
Compare
akien-mga
approved these changes
Jun 26, 2022
|
Thanks! |
akien-mga
added
the
cherrypick:3.x
|
Cherry-picked for 3.5. |
akien-mga
removed
the
cherrypick:3.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should solve godotengine/godot-proposals#4629