Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for vec2/vec4 to be used in reflect and refract #62454

Merged
merged 1 commit into from
Aug 7, 2022
Merged

Allow for vec2/vec4 to be used in reflect and refract #62454

merged 1 commit into from
Aug 7, 2022

Conversation

Geometror
Copy link
Member

I think there is no reason why this should be restricted to vec3 since GLSL and HLSL both provide vec2 and vec4 variants of reflect and refract.

@Geometror Geometror requested review from a team as code owners June 27, 2022 11:45
@Geometror Geometror added this to the 4.0 milestone Jun 27, 2022
@Geometror Geometror force-pushed the reflect-refract-vec2-vec4 branch from be282b9 to 42a09ca Compare June 27, 2022 14:18
@Geometror Geometror requested a review from a team as a code owner June 27, 2022 14:19
reduz
reduz approved these changes Aug 7, 2022
View reviewed changes
Copy link
Member

@reduz reduz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think nobody will ever use this, but no harm in adding it for compatibility with GLSL shaders.

Chaosus
Chaosus requested changes Aug 7, 2022
View reviewed changes
Copy link
Member

@Chaosus Chaosus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add this to the members dialog (in the constructor of VisualShaderEditor).

@Geometror Geometror force-pushed the reflect-refract-vec2-vec4 branch from 42a09ca to b8d5f4b Compare August 7, 2022 16:03
@Geometror
Copy link
Member Author

@Chaosus Done:)

@Chaosus Chaosus self-requested a review August 7, 2022 16:32
@akien-mga akien-mga merged commit f754dd2 into godotengine:master Aug 7, 2022
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reduz reduz reduz approved these changes

@Chaosus Chaosus Chaosus approved these changes

Assignees
No one assigned
Labels
enhancement topic:shaders
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Geometror @akien-mga @Chaosus @reduz