Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

X11: Properly check for fullscreen toggle made through the Window Manager #62551

Merged
merged 1 commit into from
Jul 1, 2022

Conversation

akien-mga
Copy link
Member

@akien-mga akien-mga commented Jun 30, 2022

Fixes #40007.

master port of #62543.

As a side note, there's quite some code duplication in the checks for WM properties, we could maybe figure out a way to make a common helper method to simplify the code (for fullscreen, maximized and minimized checks done currently, maybe more).

Fixes godotengine#40007.

Co-authored-by: Rémi Verschelde <rverschelde@gmail.com>
@akien-mga akien-mga added this to the 4.0 milestone Jun 30, 2022
@akien-mga akien-mga requested a review from bruvzg June 30, 2022 10:15
@akien-mga akien-mga requested a review from a team as a code owner June 30, 2022 10:15
@akien-mga akien-mga merged commit 110248c into godotengine:master Jul 1, 2022
@akien-mga akien-mga deleted the x11-check-fullscreen branch July 1, 2022 07:09
@akien-mga akien-mga changed the title Properly check for fullscreen toggle made through the Window Manager X11: Properly check for fullscreen toggle made through the Window Manager Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fullscreen toggle by window manager does not change OS.window_fullscreen property
3 participants