Fix find_next_valid_focus() freeze #62573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KoBeWi
added
bug
regression
cherrypick:3.x
akien-mga
approved these changes
Jun 30, 2022
|
Thanks! |
Rubonnek
added
the
cherrypick:3.5
akien-mga
removed
the
cherrypick:3.5
|
Cherry-picked for 3.5. |
akien-mga
removed
the
cherrypick:3.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #62564
find_next_valid_focus()will search for a focusable child and will go higher if it doesn't find one. What happened in #62564 was that the loop was going down and then back up, creating a weird cyclic loop. Turns out the original condition made sense, so now there's both of them :vThe new issue occurred in a dialog, which might explain why it wasn't triggered in master. But the fix is likely relevant for both branches.