Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed incorrect type display of function arguments in GDScript editor tooltips #63015

Merged
merged 1 commit into from
Aug 10, 2022

Conversation

Xwdit
Copy link
Contributor

@Xwdit Xwdit commented Jul 15, 2022

For function arguments without a defined type but with a default value set, the arguments type will be displayed as the type of the default value in the editor tooltip (should be Variant)

Fix #63017

Before this PR:
image

After:
image

@Xwdit Xwdit requested a review from a team as a code owner July 15, 2022 02:49
@Xwdit
Copy link
Contributor Author

Xwdit commented Jul 15, 2022

Also note that for the current Master branch, the default value of the function parameter will not be displayed in the tooltip, so the picture shows the effect after merging #62934 and #62994

@Xwdit Xwdit force-pushed the fix_gds_editor_tooltip_arg_type branch 2 times, most recently from 69a191e to d65d097 Compare July 15, 2022 04:34
@Chaosus Chaosus added this to the 4.0 milestone Jul 15, 2022
@akien-mga
Copy link
Member

Needs rebase to fix CI due to a temporary godot-cpp issue.

@Xwdit Xwdit force-pushed the fix_gds_editor_tooltip_arg_type branch from d65d097 to cdb71bc Compare July 15, 2022 10:42
@Xwdit
Copy link
Contributor Author

Xwdit commented Jul 15, 2022

Needs rebase to fix CI due to a temporary godot-cpp issue.

Rebased to fix CI issue

@Xwdit Xwdit force-pushed the fix_gds_editor_tooltip_arg_type branch from cdb71bc to e25c86b Compare August 10, 2022 13:06
@akien-mga akien-mga merged commit a946768 into godotengine:master Aug 10, 2022
@akien-mga
Copy link
Member

Thanks!

@Xwdit Xwdit deleted the fix_gds_editor_tooltip_arg_type branch August 10, 2022 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect type display of function arguments in GDScript editor tooltips
4 participants