[3.x] Fix CanvasItem not exiting its canvas group on canvas exit
#63234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kleonc
changed the title
CanvasItem not existing its canvas group on canvas exitCanvasItem not exiting its canvas group on canvas exit
kleonc
force-pushed
the
canvas-item-remove-from-canvas-group-3x
branch
from
e985b47
to
558b96f
Compare
lawnjelly
approved these changes
Jul 20, 2022
There was a problem hiding this comment.
I've not done anything with canvas groups, but this looks fine to me.
I was having a look at compressing some of the bloat in canvas item and now looking at it, I'm not sure we need to be storing a string per canvas item for this, but that can be for another PR.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All
CanvasItems not parented to anotherCanvasItemwithin the given canvas are added to the group specific for this canvas (on entering the canvas). However, they were not removed from such group on canvas exit which could result in unexpected/strange state (and thus behavior) like:CanvasItembeing a child of anotherCanvasItemcould still belong to a canvas group, orCanvasItemcould belong to many different canvas groups etc.Now they should be correctly removed from the canvas group on exiting the canvas.
Fixes #63183.
In action (MRP from #63183):
/ 
Scene / after
ready():3.5.rc6:Fixed behavior by manual removal from the group:
This PR:
