[3.x] Address remaining scoped storage regressions #63480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m4gr3d
added
bug
platform:android
topic:core
confirmed
regression
cherrypick:3.5
m4gr3d
force-pushed
the
fix_remaining_scoped_storage_regressions_3x
branch
from
def0f5f
to
1641f8f
Compare
akien-mga
removed
the
cherrypick:3.5
akien-mga
reviewed
Jul 26, 2022
- Accelerate common path used to check the storage scope for a given path - Update the logic for the `get_as_text()` method - previous logic loads the content of a text file one byte at a time
m4gr3d
force-pushed
the
fix_remaining_scoped_storage_regressions_3x
branch
from
1641f8f
to
fc2c202
Compare
akien-mga
approved these changes
Jul 26, 2022
|
Thanks! |
|
I am excited to test this out |
|
Thanks a lot! ;-) On my old Galaxy S6 with Android 7 it works very well now. from 3.4-stable: 15 secs |
|
Wow. I just tested and it seems super fast to start up my game now. Tested using 3.5rc8 mono with Asus zenfone max pro m1 android 10. Good job and many thank you for the contributors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_as_text()method - previous logic loads the content of a text file one byte at a timeFixes #63434
Validated the fix and the rest of the implementation with ScopedStorageTests.zip