Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] When Camera2D enters tree, ensure first update is not lost #63581

Merged
merged 2 commits into from
Jul 28, 2022

Conversation

madmiraal
Copy link
Contributor

3.x version of #63580.

@madmiraal madmiraal requested a review from a team as a code owner July 28, 2022 16:13
@Calinou Calinou added bug topic:core regression topic:2d cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release labels Jul 28, 2022
@Calinou Calinou added this to the 3.6 milestone Jul 28, 2022
@akien-mga
Copy link
Member

How safe do you think this would be for 3.5? Given that IIUC it fixes a regression so might be important to have in 3.5-stable.
I just released 3.5 RC 8 and there might not be a RC 9 so it's a bit risky to merge further fixes at this stage, but if you're confident that it's safe it might be worth it.

@madmiraal
Copy link
Contributor Author

I think it's safe. I also think it's better to have it than not to have it.

@akien-mga akien-mga modified the milestones: 3.6, 3.5 Jul 28, 2022
@akien-mga akien-mga removed the cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release label Jul 28, 2022
@akien-mga akien-mga merged commit ca49a14 into godotengine:3.x Jul 28, 2022
@akien-mga
Copy link
Member

Thanks!

@madmiraal madmiraal deleted the fix-63330-3.x branch July 28, 2022 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants