Get WebXR minimally working again in Godot 4 #64514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsnopek
force-pushed
the
webxr-master-fixup-squashed
branch
7 times, most recently
from
4320f33
to
f122812
Compare
dsnopek
force-pushed
the
webxr-master-fixup-squashed
branch
from
f122812
to
548ca2f
Compare
dsnopek
force-pushed
the
webxr-master-fixup-squashed
branch
from
548ca2f
to
b9f15fd
Compare
|
I rebased this on PR #65800, which is the latest attempt to fix the rendering issues with XR on the 'opengl3' driver. I think this one is the one! ;-) For whatever reason, this PR is no longer working on the WebXR emulator (I suspect it's something related to PR #65727) but it still works fine on an actual device. Once PR #65800 (or its successor :-)) gets merged, this one will still be ready to go in: it accomplishes what aims to do (get WeXR minimally working) and I can fix the issue with the WebXR emulator in a follow-up PR. |
dsnopek
force-pushed
the
webxr-master-fixup-squashed
branch
from
b9f15fd
to
53a3039
Compare
|
PR #65800 was merged (yay!) so I just rebased and re-tested this: it's still working just as well as my last comment! This one is ready to go :-) |
clayjohn
reviewed
Sep 19, 2022
dsnopek
force-pushed
the
webxr-master-fixup-squashed
branch
from
53a3039
to
22bfba3
Compare
dsnopek
force-pushed
the
webxr-master-fixup-squashed
branch
from
22bfba3
to
b5c14e5
Compare
akien-mga
approved these changes
Sep 20, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft PR, because it includes the changes from PR #65800 which is necessary for this to work.Not a draft anymore!
This includes the changes from PR #55869, which got merged into 3.x only, since it was impossible to port to Godot 4 without WebGL support (which we now have, yay!)
With the PR, WebXR will render fine on mono devices (like smartphone AR), but with stereo devices it will only render the left eye, because the 'opengl3' driver doesn't support multiview yet.