Add NoiseTexture3D and rename NoiseTexture to NoiseTexture2D.

[Lasuch69]

Add NoiseTexture3D and rename NoiseTexture to NoiseTexture2D.

This commit implements new resource NoiseTexture3D. Unfortunately it doesn't support seamless generation.
Note: Mipmaps are buggy as some resolutions (only lower than default) break format required size and can't intialize. Also if you change resolution too fast you get a size mismatch error.
As for Noise resource modification i only changed arguments for generation to support custom depth allowing for 3D coordinates to be used.

modified:   modules/noise/config.py
modified:   modules/noise/doc_classes/Noise.xml
renamed:    modules/noise/doc_classes/NoiseTexture.xml -> modules/noise/doc_classes/NoiseTexture2D.xml
new file:   modules/noise/doc_classes/NoiseTexture3D.xml
modified:   modules/noise/editor/noise_editor_plugin.cpp
modified:   modules/noise/noise.cpp
modified:   modules/noise/noise.h
renamed:    modules/noise/noise_texture.cpp -> modules/noise/noise_texture_2d.cpp
renamed:    modules/noise/noise_texture.h -> modules/noise/noise_texture_2d.h
new file:   modules/noise/noise_texture_3d.cpp
new file:   modules/noise/noise_texture_3d.h
modified:   modules/noise/register_types.cpp

Bugsquad edit: This closes godotengine/godot-proposals#4946.

[Geometror]

Thanks for your work on this :)
First things first: It is recommended that you never use your master branch for pull requests. While it essentially works for now, you can quickly run into problems this way.
Your pull request description contains information about which files were modified/added/removed, which is redundant since the GitHub UI already shows this. It would be more helpful to provide a short summary about what your PR does (although more detailed than the title)/what remains to do or which problems you faced.
On a first glance the implementation looks quite good to me, but I need to review it more thoroughly.

[Lasuch69]

Thanks for your work on this :) First things first: It is recommended that you never use your master branch for pull requests. While it essentially works for now, you can quickly run into problems this way. Your pull request description contains information about which files were modified/added/removed, which is redundant since the GitHub UI already shows this. It would be more helpful to provide a short summary about what your PR does (although more detailed than the title)/what remains to do or which problems you faced. On a first glance the implementation looks quite good to me, but I need to review it more thoroughly.

I will try to improve on that. Thanks for advice!

[Geometror]

In addition to my comment before,
https://docs.godotengine.org/en/latest/community/contributing/pr_workflow.html provides a very helpful and detailed explanation of the Godot pull request workflow.

[Lasuch69]

I needed to fix a couple of typos and add comments

[Lasuch69]

updated fork

[Lasuch69]

i hate my life

rebase conflict defeated me

i will try to improve it as much as possible and i give up for now with PR's

[Calinou]

i hate my life

rebase conflict defeated me

i will try to improve it as much as possible and i give up for now with PR's

Do you still have the code somewhere? This PR no longer includes any code, which makes it impossible for other people to salvage your work (if you no longer have time to work on it).

[Lasuch69]

Do you still have the code somewhere? This PR no longer includes any code, which makes it impossible for other people to salvage your work (if you no longer have time to work on it).

I do. Here: https://github.com/Lasuch69/add_noisetexture3d/tree/add-noisetexture3d The problem is this function: https://github.com/Lasuch69/add_noisetexture3d/blob/cdf5a02c276165c27ad7a97d716b14d7a4106c47/drivers/vulkan/rendering_device_vulkan.cpp#L1147 on "for" loop iterates on mipmap levels (u_int) and sometimes it doesn't take into account lowest layers for example 1x1x4 is 7 pixels in total with mipmaps and godot only sees 4 because this function iterates only through layer 0. Layers are created by width and height only and depth isn't taken into account. Tbh i don't know what to do so feel free to do anything with this code you want.