Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove String::erase method declaration #64714

Merged
merged 1 commit into from
Sep 1, 2022

Conversation

Chaosus
Copy link
Member

@Chaosus Chaosus commented Aug 22, 2022

It's just an old leftover, as discussed in the rocket chat.

@Chaosus Chaosus requested a review from a team as a code owner August 22, 2022 07:31
@Chaosus Chaosus added this to the 4.0 milestone Aug 22, 2022
@akien-mga
Copy link
Member

Let's wait for the CI backlog to be somewhat reduced before merging as this will require a good hour to rebuild all platforms and update the master cache for future PRs/merges.

@akien-mga akien-mga merged commit 10bd79c into godotengine:master Sep 1, 2022
@akien-mga
Copy link
Member

Thanks!

@Chaosus Chaosus deleted the string_remove_erase branch September 2, 2022 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants