Make ImageLoader take bit field flags
#64776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
Aug 23, 2022
YuriSizov
force-pushed
the
import-images-moar-flags
branch
from
386c81d to
672e9d6
Compare
kleonc
approved these changes
Aug 23, 2022
|
Since this is ready, I'd prefer we merged 🙃 Shouldn't be hard for @Faless to rebase his PR and expose flags and all that. |
fire
approved these changes
Aug 24, 2022
|
I have no problem rebasing my PR, but shouldn't this use |
|
@Faless I've references some similar code in the resource saver, I think. I guess |
|
IMO this stuff could use |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on godotengine/godot-proposals#5034 I concluded that I need to pass more flags to the individual image format loaders from the import settings. Existing method signature supports
force_linear, and half of the importers don't even use it. So I figured that instead of adding a new flag at the end of the method and growing its list of parameters — it's better to reuse the existing parameter, but convert it to a bit field.This PR doesn't add anything new, just converts the parameter and introduces an enum. I guess that this is compat breaking for modules, but otherwise the classes aren't exposed, I don't think.
This work is kindly sponsored by the Dialogic project.