Discontinued spherical_interpolate_with() in Transform3D
#65131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TokageItLab
force-pushed
the
transform-with
branch
from
7eb35f0 to
c139d9e
Compare
fire
approved these changes
Aug 31, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I implemented
Basis::lerp()forNode3D::rotation_edit_mode, I addedTransform3D::spherical_interpolate_with()separately fromTransform3D::interpolate_with(), but I think it will never be used in practice.Also,
interpolate_with()existed inTransform2D, which usesslerp()as its default and was not consistent. So I think that rather than implementingspherical_interpolate_with()in Transform2D, it is a right way to implementspherical_interpolate_with()in Transform3D and doslerp()inTransform3D::interpolate_with().