Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add strip_bbcode() method to String #65384

Closed
wants to merge 1 commit into from
Closed

Add strip_bbcode() method to String #65384

wants to merge 1 commit into from

Conversation

ztc0611
Copy link
Contributor

@ztc0611 ztc0611 commented Sep 5, 2022

Adds a function to strip bbcode tags out of strings.

Example Code:

var s = "[color=#ffffff]Hello![/color]
print(s.strip_bbcode())

Result: Hello

Closes godotengine/godot-proposals#5056

@ztc0611 ztc0611 requested review from a team as code owners September 5, 2022 21:18
@Calinou Calinou added this to the 4.0 milestone Sep 5, 2022
@Calinou Calinou added the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Sep 5, 2022
@ztc0611 ztc0611 requested review from a team as code owners September 6, 2022 18:57
@ztc0611
Copy link
Contributor Author

ztc0611 commented Sep 6, 2022

Sorry for that, I made the mistake of putting new changes on the same branch as this PR. Corrected now.

@ztc0611
Copy link
Contributor Author

ztc0611 commented Sep 11, 2022

Any update on this? Since I was silly and didn't correctly branch from master, it means I can't submit my other PR about re-adding the center window function until this one is gone.

core/string/ustring.cpp Outdated Show resolved Hide resolved
core/string/ustring.cpp Outdated Show resolved Hide resolved
core/string/ustring.cpp Outdated Show resolved Hide resolved
@Chaosus
Copy link
Member

Chaosus commented Sep 11, 2022

Any update on this? Since I was silly and didn't correctly branch from master, it means I can't submit my other PR about re-adding the center window function until this one is gone.

Accepting the pull request is usually a long process - some hours, days or weeks, and sometimes it even takes years, in general if you have such problem - there is no shame to close the PR and then re-open a fixed version.

Co-authored-by: Yuri Rubinsky <chaosus89@gmail.com>
@YuriSizov YuriSizov requested review from bruvzg and Chaosus September 12, 2022 14:51
@ztc0611 ztc0611 closed this by deleting the head repository Sep 15, 2022
@akien-mga akien-mga added archived and removed cherrypick:3.x Considered for cherry-picking into a future 3.x release labels Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a function to erase BBCode from a String, without depending on RichTextLabel
4 participants