Low priority redraw request for AnimatedSprite #65663

lawnjelly · 2022-09-11T18:16:01Z

Prevents animated sprite from creating continuous redraws in vital_redraws_only mode.

Notes

This has no effect except when vital_redraws_only mode is on.
Just noticed this case that I have not seen previously, in a user MRP.
See Add editor vital redraws only option #53463 for the original PR introducing vital redraws and More low priority redraw request cases #61965 adding more cases.
Ideally it would be nice to switch off internal process, but this simple technique gets most of the benefit with no risk.

Prevents animated sprite from creating continuous redraws in vital_redraws_only mode.

akien-mga · 2022-09-12T09:37:43Z

Thanks!

akien-mga · 2022-09-20T08:23:35Z

Cherry-picked for 3.5.1.

Low priority redraw request for AnimatedSprite

54a939a

Prevents animated sprite from creating continuous redraws in vital_redraws_only mode.

lawnjelly requested a review from a team as a code owner September 11, 2022 18:16

lawnjelly added enhancement topic:editor labels Sep 11, 2022

lawnjelly added this to the 3.6 milestone Sep 11, 2022

lawnjelly added the cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release label Sep 11, 2022

lawnjelly marked this pull request as draft September 11, 2022 18:19

lawnjelly marked this pull request as ready for review September 11, 2022 18:56

akien-mga approved these changes Sep 12, 2022

View reviewed changes

akien-mga merged commit 5ff2c77 into godotengine:3.x Sep 12, 2022

lawnjelly deleted the vital_updates_animated_sprite branch September 12, 2022 09:59

akien-mga removed the cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release label Sep 20, 2022