Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GDExtension] Implement support for typed arrays. #65817

Merged
merged 1 commit into from
Sep 23, 2022

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Sep 15, 2022

Exposes missing Array methods, and add typed arrays to the GDExtension JSON.

godot-cpp part - godotengine/godot-cpp#841

@raulsntos
Copy link
Member

Does this supersede #64249?

@bruvzg bruvzg marked this pull request as ready for review September 23, 2022 07:17
@bruvzg bruvzg requested review from a team as code owners September 23, 2022 07:17
@bruvzg
Copy link
Member Author

bruvzg commented Sep 23, 2022

As usual, it will need rebase after godotengine/godot-cpp#841 merge to pass CI.

Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, but I don't see what are the TypedArray related changes in TextServers?

@akien-mga
Copy link
Member

This also the discussion on #64249 on how to handle this kind of generics in different languages.

@bruvzg
Copy link
Member Author

bruvzg commented Sep 23, 2022

Looks fine, but I don't see what are the TypedArray related changes in TextServers?

TextServer already was using TypedArrays (and was unbuildable for this reason), TS changes are to make it buildable as an extension again, but not directly related to TypedArray.

@bruvzg
Copy link
Member Author

bruvzg commented Sep 23, 2022

This also the discussion on #64249 on how to handle this kind of generics in different languages.

TypedArrays are its own subtype in the engine, so for godot-cpp method binds should have it as an independent type as well.

The generics, like Dictionary content or more specific contents of the generic Array, are used only for properties, and irrelevant for C++ bindings. So I guess it's better to have it as extra info (like in #64469) for other language bindings, if they need it.

@akien-mga akien-mga modified the milestones: 4.x, 4.0 Sep 23, 2022
@akien-mga
Copy link
Member

I'll merge even though the CI build with godot-cpp hasn't completed yet, to unblock other PRs (as the counterpart merged in godot-cpp breaks building against current Godot code until this is merged).

@akien-mga akien-mga merged commit 006e345 into godotengine:master Sep 23, 2022
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants