-
-
Notifications
You must be signed in to change notification settings - Fork 21.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement 'OS::shell_show_in_explore()' for FilesystemDock and expose… #65890
implement 'OS::shell_show_in_explore()' for FilesystemDock and expose… #65890
Conversation
What would be the benefit of this instead of using it as we currently do and let the operating system handle the file protocol scheme as it sees fit? |
Seems like it closes godotengine/godot-proposals#3251 |
This only effective for the popop mune's item |
Oh ....my garbage English.... |
I think if that's the use case for it, something like this is better than adding a whole new method: |
On macOS, you can use the following code, no idea if there's a universal equivalent for Linux: NSArray* urls = [NSArray arrayWithObjects:[NSString stringWithUTF8String:p_uri.utf8().get_data()], nullptr];
[[NSWorkspace sharedWorkspace] activateFileViewerSelectingURLs:urls]; |
… to GDScript fix methods names
….com/Daylily-Zeleen/godot into daylily_zeleen/shell_show_in_explore
… to GDScript fix methods names implement 'OS::shell_show_in_explore()' for FilesystemDock and expose to GDScript fix methods names
….com/Daylily-Zeleen/godot into daylily_zeleen/shell_show_in_explore
I can't debug on macos so I can't be responsible for this |
I think this new method is a util for Plugin developer. |
I still can't squash commts, so I will close this one and open a new pr. |
Repalced by #65906 |
Implement 'OS::shell_show_in_explore()' for FilesystemDock and expose to GDScript.
Currently only implement for Windows, because I only have a windows device.
On other platforms, it will fallback to origin action.
I hope someone can implement for other platforms.
QQ.20220916183403.mp4