Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an editor option to copy system info to clipboard #65902

Merged
merged 1 commit into from
May 27, 2023

Conversation

MJacred
Copy link
Contributor

@MJacred MJacred commented Sep 16, 2022

EDIT: The output result of this PR was changed to single-line in this PR to better align with the GitHub bug reporting template:

new output format:
Godot v4.1.dev (bc19b5abf) - Ubuntu 20.04.6 LTS (Focal Fossa) - Vulkan (Forward+) - dedicated NVIDIA GeForce GTX 970 (nvidia; 510.108.03) - Intel(R) Core(TM) i7-10700KF CPU @ 3.80GHz (16 Threads)


Closes godotengine/godot-proposals#4732 (Author said it's fine)

copy sys info

copies markdown friendly syntax into clipboard

* OS: Ubuntu 20.04.5 LTS (Focal Fossa)
* Godot Version: 4.0.beta.custom_build
* Rendering Driver: vulkan
* Rendering Method: Forward+
* Graphics Card: NVIDIA GeForce GTX 970 (dedicated)
* Graphics Card Driver: nvidia, version 510.85.02
* CPU: Intel(R) Core(TM) i7-10700KF CPU @ 3.80GHz (16 Threads)

Will add graphics card driver name + version info in a future PR, once I've made more progress (got it figured out for Linux)
DONE ✔️

@MJacred MJacred requested a review from a team as a code owner September 16, 2022 13:35
@Calinou
Copy link
Member

Calinou commented Sep 16, 2022

See also godotengine/godot-proposals#4732, which proposes a more elaborate solution.

That said, I think the way this PR works is pretty good already. I'd consider it sufficient to close godotengine/godot-proposals#4732 🙂

editor/editor_node.cpp Outdated Show resolved Hide resolved
@MJacred
Copy link
Contributor Author

MJacred commented Sep 16, 2022

@Calinou: Indeed. For now, I wanted to get something useful for everybody real quick. I want to go full fancy with this later, but still thinking about grouping data and so. Thanks for the proposal reference. I'll take some inspiration from steam/blender

@MJacred
Copy link
Contributor Author

MJacred commented Oct 11, 2022

@Calinou / @akien-mga: This PR has been updated with merge of #66102. Are code and info selection ok like this?

@MJacred
Copy link
Contributor Author

MJacred commented Dec 2, 2022

ping @Calinou / @akien-mga

editor/editor_node.cpp Outdated Show resolved Hide resolved
editor/editor_node.cpp Outdated Show resolved Hide resolved
@MJacred MJacred requested review from a team as code owners December 2, 2022 15:18
@MJacred MJacred requested review from akien-mga and removed request for Calinou December 2, 2022 15:20
core/os/os.cpp Outdated Show resolved Hide resolved
editor/editor_node.cpp Outdated Show resolved Hide resolved
editor/editor_node.cpp Outdated Show resolved Hide resolved
editor/editor_node.cpp Outdated Show resolved Hide resolved
@MJacred MJacred requested a review from a team as a code owner May 23, 2023 14:09
@MJacred
Copy link
Contributor Author

MJacred commented May 23, 2023

@Calinou: done. I merged Godot version and System information into Environment information to reflect the new Editor functionality. What do you think?

EDIT: I can extract Godot version again, if you think this would cause more harm than do good

preview:

https://github.com/MJacred/godot/blob/editor/copysysteminfo/.github/ISSUE_TEMPLATE/bug_report.yml

@akien-mga akien-mga requested a review from Calinou May 23, 2023 17:12
plus minor static-related fixes
* linuxbsd: get_systemd_os_release_info_value() -> static breaks usage if used multiple times
* windows/linuxbsd: get_video_adapter_driver_info() writes info into static
* linuxbsd: get_distribution_name() + get_version() -> write bsd fallback into static variable
* windows/uwp/android: remove unnecessary use of static
@YuriSizov YuriSizov changed the title Improve Bug Reporting UX: Copy system info to clipboard Add an editor option to copy system info to clipboard May 27, 2023
@YuriSizov YuriSizov merged commit c670c43 into godotengine:master May 27, 2023
@YuriSizov
Copy link
Contributor

Thanks!

@MJacred MJacred deleted the editor/copysysteminfo branch May 27, 2023 18:14
@Calinou
Copy link
Member

Calinou commented May 28, 2023

Unfortunately, using a multiline text field in the issue template prevents browser autocompletion from working (since browsers only autocomplete singled-line inputs). I'm thinking we should revert that particular change as I personally rely on this a lot (and so does @KoBeWi).

@MJacred Could you make the button copy a single-line output (separating each element with - + spaces for instance), and make the issue template's system information single-line again?

@MJacred
Copy link
Contributor Author

MJacred commented May 28, 2023

using a multiline text field in the issue template prevents browser autocompletion from working

that's totally understandable. jeeze, what a pain in the neck…

Could you make the button copy a single-line output […]?

Yeah, sounds reasonable. And then also remove the * character
I could add html <br>, which should make it multiline again upon rendering the markdown, but that probably doesn't fly well with users.
Hm… though I could encapsulate each instance with ``. What do you think, @Calinou ? -> OS: Ubuntu 20.04.5 LTS (Focal Fossa) - Godot Version: 4.0.beta.custom_build - etc.

@akien-mga
Copy link
Member

I think a single line with all this information might be pretty verbose / hard to parse visually.
It would likely need rethinking to make it less verbose, so it doesn't over explained what the information is, e.g.:

Ubuntu 20.04.5 LTS - Godot 4.0.beta.custom_build - Vulkan (Forward+) - NVIDIA GeForce GTX 970 (driver 510.85.02) - Intel(R) Core(TM) i7-10700KF CPU @ 3.80GHz (16 Threads)

Maybe even like this it might be a bit too much. (BTW we should also get the commit hash for the Godot version, which is more useful than custom_build.)

@MJacred
Copy link
Contributor Author

MJacred commented May 28, 2023

might be pretty verbose / hard to parse visually.

Yeah, that's why this is a pain in the neck… Removing the info classifications ("OS", "Godot Version", etc.) sounds feasible

BTW we should also get the commit hash for the Godot version, which is more useful than custom_build.

Hm… should be possible with version.h/VERSION_HASH. I'll check it out

Maybe even like this it might be a bit too much

I'll make a PR. Then we can check it out directly

@YuriSizov
Copy link
Contributor

Cherry-picked for 4.0.4. The entire quadruple: #58518, #65902, #77574, #77929

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a System Information dialog to streamline the bug reporting process
4 participants