Change UndoRedo to use Callables #66070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KoBeWi
force-pushed
the
call_of_undo
branch
from
d51c08a
to
f7ddf21
Compare
KoBeWi
force-pushed
the
call_of_undo
branch
from
f7ddf21
to
b399719
Compare
|
This also closes godotengine/godot-proposals#5038 |
|
Thanks! |
This was referenced Feb 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes UndoRedo use Callables. Everything now uses EditorUndoRedoManager, so this is a pretty low-impact change. But it paves the road for changing EditorUndoRedoManager too in the future.
Note that, while you can use GDScript lambdas in UndoRedo and it works, right now it will print an error, because the method name can't be obtained. We need some sort of "get method safe" in CallableCustom to prevent this. For now it's not important though.
Bugsquad edit:
UndoRedo.add_do/undo_method()use Callable godot-proposals#5038