Minor enhancements to the GLTF module (lights and docs) #66087
Conversation
modules/gltf/SCsub
Outdated
| env_gltf.add_source_files(env.modules_sources, "structures/*.cpp") | ||
| SConscript("extensions/SCsub") |
There was a problem hiding this comment.
What's the use for this? It's not done for structures nor editor, if there's no custom config to set for this folder / a sub env, I don't see how it makes things better.
There was a problem hiding this comment.
In isolation it's indeed not better, but it's planning for future PRs where there is more complex logic. In the future I'm planning to have extensions/ to have subfolders in it. If you want I can remove it from this PR, and instead we can introduce this SCsub when it becomes useful.
There was a problem hiding this comment.
I guess it's fine if you're confident that these future PRs will actually be merged as you envision them. But generally speaking yes, it's best to leave out such future proofing and do the change when it's actually useful.
aaronfranke
force-pushed
the
gltf-minor-light
branch
from
afe09ec to
6f4d249
Compare
Minor enhancements to the GLTF module (lights and docs)
|
I merged a second after you force pushed so it didn't work :) Merged in 63c0dc6. |
Minor misc enhancements to the GLTF module. Fix some minor things with lights, rename
Ref<GLTFNode> ntogltf_node, give the extensions folder its own SCsub, and add some documentation.