Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Callable: add callv method #66177

Merged
merged 1 commit into from
Sep 23, 2022
Merged

Conversation

rburing
Copy link
Member

@rburing rburing commented Sep 20, 2022

Analogous to the existing callv method on Object, this new method on Callable takes a single array of arguments.

This method has the advantage that it can be called from GDExtension without vararg template shenanigans. For example, the automatically generated bindings in godot-cpp will work out of the box. This is important as it provides the first way to actually call a Callable using godot-cpp. (Better ways may be implemented later.)

Together with #65828, this will unblock ongoing work on custom physics servers.

@rburing rburing requested review from a team as code owners September 20, 2022 20:57
@akien-mga akien-mga added this to the 4.0 milestone Sep 20, 2022
@rburing rburing marked this pull request as draft September 20, 2022 21:51
@rburing rburing marked this pull request as ready for review September 20, 2022 22:21
This method can be called from GDExtension.
Copy link
Member

@bruvzg bruvzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, since Object have one, I do not see any reason not to have it in Callable.

@akien-mga akien-mga merged commit ee95cc0 into godotengine:master Sep 23, 2022
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants