Fix Editor Description tooltip not changing until scene is reopened #66266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
added
bug
topic:editor
cherrypick:3.x
|
Might be worth guarding against the case where the string doesn't change, to prevent needlessly updating the tree. This sounds like it would update the tree for every node in a given scene when opening the scene. If you only handle nodes with a non-empty description it's a bit better, though still seems a bit overkill when many nodes have descriptions. Queuing an update on SceneTree for the next frame might be better. |
reduz
approved these changes
Jan 19, 2023
|
A bit overkill, but I guess ok for what it is |
akien-mga
reviewed
Jan 19, 2023
You still need to select another node to see the tooltip updated first, but you no longer need to save and reopen the scene to view the updated tooltip.
Calinou
force-pushed
the
editor-description-fix-tooltip-update
branch
from
7984c51
to
9f026d5
Compare
|
Thanks! |
akien-mga
removed
the
cherrypick:3.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You still need to select another node to see the tooltip updated first, but you no longer need to save and reopen the scene to view the updated tooltip.
The solution is based on #61531 (thanks @Dentyr), but is only applied in the editor as it's not needed outside the editor.
This closes #61521.