Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to choose opening bottom panel on play #66503

Closed
wants to merge 1 commit into from

Conversation

jmb462
Copy link
Contributor

@jmb462 jmb462 commented Sep 27, 2022

Fix #66496

Issue fixed :

The editor setting run/output/always_open_output_on_play always open Debbuger panel when set to false.

Fix proposal :

Allow to choose opening panel between Output / Debugger / None (keeps panel unchanged on game launch)

image

@jmb462 jmb462 requested review from a team as code owners September 27, 2022 15:30
@Calinou
Copy link
Member

Calinou commented Sep 27, 2022

I think None should be the first option instead of the last. In general, the "disabled" state for an enum should be listed first.

@jmb462
Copy link
Contributor Author

jmb462 commented Sep 27, 2022

I think None should be the first option instead of the last. In general, the "disabled" state for an enum should be listed first.

I though that default value first make sense. I've modified the order to put None at first.

@RedMser
Copy link
Contributor

RedMser commented Sep 28, 2022

I was going to suggest updating always_close_output_on_stop editor setting as well, since it should also close the debugger now.
But it seems like that setting is named wrongly and always closes the bottom panel no matter what. 👀

If there's a way to rename a setting and keep its old value, that would be nice, but I don't see such a mechanism in place...


Then again, the category Run -> Output also doesn't make much sense for this setting anymore...

@jmb462
Copy link
Contributor Author

jmb462 commented Sep 28, 2022

The debugger is always closed on stop, whatever the always_close_output_on_stop is.
So this setting actualy only acts on output panel.

Maybe we can have :

Run > Bottom panel

  • Output Font Size
  • Always clear output on Play
  • Open Bottom Panel On Play (None / Output (default) / Debugger)
  • Close Bottom Panel On Stop (this setting should act on any panel which has been autoopened at play but not if the panel was already opened before lauching the app) Actually, it's closing the output panel even if it was already open before play.

EDIT :

I've implemented this logic (without pushing it to repo) but for debugger panel, there is an other option which conflict with editor settings in the script menu :
image

I don't think it's a good idea to keep both. So I don't really know what to do with debugguer autoclosing on stop.

@YuriSizov YuriSizov modified the milestones: 4.0, 4.1 Feb 10, 2023
@YuriSizov YuriSizov requested a review from a team February 10, 2023 15:28
@wingedadventurer
Copy link
Contributor

i also think that the default behavior should be to not modify the bottom panel at all. so whatever the user had in the editor when running the game, it stays that way. if somebody needs a specific panel/tab to be visible, they can open it beforehand. currently no other panel changes in the engine except for bottom panel.

my problem right now is, i'm placing tiles via TileMap tab at the bottom, and every time i run the game it switches to Output or Debugger tab (depending on what's chosen in the settings), disrupting the flow.

@KoBeWi
Copy link
Member

KoBeWi commented Jul 24, 2024

Superseded by #91033
Thanks for the contribution nonetheless.

@KoBeWi KoBeWi closed this Jul 24, 2024
@KoBeWi KoBeWi removed this from the 4.3 milestone Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Always Open Output On Play opens the debugger when set to false
7 participants