Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this change?
When calling
Node::move_child()
it currently expectsto_position
which can get very confusing when using GDScript. I was wondering why I was unable to pass an actual position (Vector2
) into it. Then I realized that by "position" we actually mean the "index" in the node hierarchy. To avoid mixing concepts together I decided to rename pos to index. This should not break compatibility as it is just an internal rename + documentation update.