Fix differences between Windows and linuxbsd Display Server #67903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sauermann
force-pushed
the
fix-startup-windows-mouse-exit-event
branch
from
06de9d9 to
5a2eda7
Compare
Sauermann
changed the title
bruvzg
approved these changes
Oct 28, 2022
Sauermann
force-pushed
the
fix-startup-windows-mouse-exit-event
branch
2 times, most recently
from
f14b4ed to
7223fca
Compare
Fix that Windows receive WINDOW_EVENT_MOUSE_EXIT on startup. When moving the mouse cursor from one window to a different one, make sure that the first window receives the WINDOW_EVENT_MOUSE_EXIT event before the second window receives the WINDOW_EVENT_MOUSE_ENTER event. Send Mouse-Move events also for Windows, that are currently not focused. For determining the currently hovered window, consider not just the currently focused window, but also other windows. Send mouse move events to focused window instead of hovered window.
Sauermann
force-pushed
the
fix-startup-windows-mouse-exit-event
branch
from
7223fca to
4bd601d
Compare
clayjohn
approved these changes
Oct 28, 2022
|
Looks good, thanks! |
This was referenced Oct 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make adjustments to
DisplayServerWindowsto reduce the differences toDisplayServerX11.Prerequisite for #67791
Fix that Windows receive
WINDOW_EVENT_MOUSE_EXITon startup. (fix #67898)When moving the mouse cursor from one window to a different one, make sure that the first window receives the
WINDOW_EVENT_MOUSE_EXITevent before the second window receives theWINDOW_EVENT_MOUSE_ENTERevent.Send Mouse-Move events also for Windows, that are currently not focused.
For determining the currently hovered window, consider not just the currently focused window, but also other windows.
Send mouse move events to focused window instead of hovered window.
Update 2022-10-28: Code cleanup