GDScript: Rework type and member resolution #68086
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The main problem right now is that scripts don't get added to |
rune-scape
force-pushed
the
rune-simplify-extends
branch
from
7ddc1ac to
5c5c73b
Compare
rune-scape
changed the title
resolve_datatype()
rune-scape
force-pushed
the
rune-simplify-extends
branch
from
5c5c73b to
897cbcf
Compare
|
@rune-scape make sure to squash all your commits into one. |
rune-scape
force-pushed
the
rune-simplify-extends
branch
3 times, most recently
from
cc15fd0 to
fd4fde3
Compare
rune-scape
changed the title
resolve_datatype()
rune-scape
force-pushed
the
rune-simplify-extends
branch
from
fd4fde3 to
76132ed
Compare
# Conflicts: # modules/gdscript/gdscript_analyzer.cpp
rune-scape
force-pushed
the
rune-simplify-extends
branch
from
76132ed to
802fc68
Compare
|
this is bloated, im splitting it into multiple PRs and this one will go back to reworking datatype resolution |
|
actually i'm closing this as it's replacement will look completely different and be much smaller |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allows true out of order member resolution
resolve_datatype()usesreduce_identifier_from_base()to reduce duplicated code and improve errors.parser uses
TypeNodewhen parsing extends, to reduce duplicated code and improve errors.changed filesystem cache separator, because it clashes with GDScript inner class separators "::" > ":|:" (maybe it should be changed to json or something)