Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change docs' Typed Array & void representation #68159

Merged
merged 1 commit into from
Nov 15, 2022

Conversation

Mickeon
Copy link
Contributor

@Mickeon Mickeon commented Nov 2, 2022

This PR changes the built-in Documentation, to display typed Arrays in the same way as they are defined in GDScript.

As a bonus, because it tackles the same piece of code, it also modifies return values of void to be darkened, as well as displaying a tooltip on hover.

Before After
image image

@Chaosus Chaosus modified the milestones: 4.x, 4.0 Nov 2, 2022
@Mickeon Mickeon changed the title Change built-in docs Array's return value to match GDScript Change docs' Typed Array & void representation Nov 2, 2022
editor/editor_help.cpp Outdated Show resolved Hide resolved
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We approved this in PR review meeting, and agreed that we prefer the variant with no space in Array[Type].

Typed Arrays now look the same as to how they're defined in GDScript.
Also modifies "void" to be darkened and show a tooltip.
@Mickeon
Copy link
Contributor Author

Mickeon commented Nov 15, 2022

Aaand done

@akien-mga akien-mga merged commit e1ddd74 into godotengine:master Nov 15, 2022
@akien-mga
Copy link
Member

Thanks!

@Mickeon Mickeon deleted the doc-help-return-array branch November 15, 2022 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants