Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove fix leftover that caused cyclic load issues #68872

Merged
merged 1 commit into from
Nov 19, 2022

Conversation

adamscott
Copy link
Member

@adamscott adamscott commented Nov 19, 2022

This PR removes an attempt that was leftover in the #67714 PR which was merged a few hours ago.

The code removed was causing issues like this one:

Loading resource: res://Nodes/Technical/Jukebox.tscn
ERROR: Another resource is loaded from path 'res://Nodes/Technical/Jukebox.tscn::1' (possible cyclic resource inclusion).
   at: set_path (core/io/resource.cpp:75)
ERROR: Another resource is loaded from path 'res://Nodes/Technical/Jukebox.tscn::2' (possible cyclic resource inclusion).
   at: set_path (core/io/resource.cpp:75)
ERROR: Another resource is loaded from path 'res://Nodes/Technical/Jukebox.tscn::3' (possible cyclic resource inclusion).
   at: set_path (core/io/resource.cpp:75)
ERROR: Another resource is loaded from path 'res://Nodes/Technical/Jukebox.tscn::4' (possible cyclic resource inclusion).
   at: set_path (core/io/resource.cpp:75)
ERROR: Another resource is loaded from path 'res://Nodes/Technical/Jukebox.tscn::5' (possible cyclic resource inclusion).
   at: set_path (core/io/resource.cpp:75)
ERROR: Another resource is loaded from path 'res://Nodes/Technical/Jukebox.tscn::6' (possible cyclic resource inclusion).
   at: set_path (core/io/resource.cpp:75)
ERROR: Another resource is loaded from path 'res://Nodes/Technical/Jukebox.tscn::AnimationLibrary_3jtqj' (possible cyclic resource inclusion).
   at: set_path (core/io/resource.cpp:75)

It was an attempt to fix- #61386.

@adamscott adamscott requested a review from a team as a code owner November 19, 2022 04:42
@Chaosus Chaosus added this to the 4.0 milestone Nov 19, 2022
@Chaosus Chaosus merged commit c2f0353 into godotengine:master Nov 19, 2022
@Chaosus
Copy link
Member

Chaosus commented Nov 19, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants