Fixes and improvements to Gradient preview #68964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MewPurPur
force-pushed
the
tweak-gradient-editor
branch
from
7034ca8 to
b511256
Compare
MewPurPur
changed the title
MewPurPur
force-pushed
the
tweak-gradient-editor
branch
from
b511256 to
d99a958
Compare
|
Ooh, while at it, I can also fix the thing with handles blending in with gray colors Edit: Doned. Just checks if value is high or low, and draws black or white based on it. Before:
After:
|
MewPurPur
force-pushed
the
tweak-gradient-editor
branch
from
d99a958 to
2f01537
Compare
MewPurPur
changed the title
MewPurPur
force-pushed
the
tweak-gradient-editor
branch
from
2f01537 to
3c54d87
Compare
akien-mga
approved these changes
Nov 22, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR takes the handles' width into consideration when drawing color ramps, so they don't collide with other elements or get outside of the preview.
Before:
After:
It also draws the focus rect earlier, making it not overlap the handles.
Before:
After: